Add turbo.define option
#71802
Open
Add turbo.define option
#71802
+100
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
added
Documentation
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
timneutkens
reviewed
Oct 24, 2024
| @@ -169,6 +169,7 @@ export function getDefineEnv({ | |||
| }), | |||
| 'process.turbopack': isTurbopack, | |||
| 'process.env.TURBOPACK': isTurbopack, | |||
| ...(isTurbopack ? config.experimental.turbo?.define : {}), | |||
There was a problem hiding this comment.
I think this needs to be handled slightly differently to make sure it doesn't add keys that conflict with built-in features. Something like this to error:
const userDefines = isTurbopack ? config.experimental.turbo?.define : {}
for (const key in userDefines) {
if(defineEnv.hasOwnProperty(key)) {
throw new Error('descriptive error message about the defined key trying to override a built-in value')
}
defineEnv[key] = userDefines[key]
}
|
I just had the dumb realization that the It doesn't do the exact same thing but very often it might just be enough 🤔 Feel free to make the call that this PR is unnecessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
turbo.defineoption to next.config.js to statically replace any variables during build-time for Turbopack. This is similar to Webpack'sDefinePlugin.Relates to: #71476